Kodi adsp biquad filters addon

giaur500

Hello,
I don't know who is responsible for openelec repository for OrangePI, so need to ask. There is important update for Kodi Adsp Biquad Filters addons. It fixes saving equalizer settings which was broken before. Update is critical, without a fix it's not possible to save settings properly - this makes addon unusable.

So - can anybody pull latest changes from github:
https://github.com/AchimTuran/ad ... 9e0832966c76dd3d68b
Recompile addon and push zip to opi Openelec repo? Or share zip?

@jernej?

jernej

Well, keeping up with everything is extremely hard, especially now that I haven't much free time. If you would prepare package, then I will put it in repo, otherwise too much work for some fix which didn't hit official repo yet. If it would, compile would be trivial.

giaur500

Can you point me some direction how to compile that addon from his repo? I have some time but this does not look so easy

jernej

giaur500 replied at 2016-6-23 17:31
Can you point me some direction how to compile that addon from his repo? I have some time but this d ...

Now that I thought about it, there is relatively easy way. In folder packages/addons/official/kodi-addons/adsp.biquad.filters create new folder "patches". Create a patch which fixes the issue against https://github.com/kodi-adsp/adsp.biquad.filters @ d63d8ac and put it into that folder. If you are lucky enough, just download that change you referenced as a patch (by adding ".patch" at the end of the URL) and put it inside. If you are not so lucky, you will have to redo the patch. Then just try to build the addon according to FAQ. If build fails, you must fix your patch.

giaur500

Ok, it seems I need to start with preparing build environment. But I assume you have build environment already configured, can you try to apply patch when you compile Openelec again, and rebuild also that addon?

Now I'm reading your faq, when I succeded I will share zip.

jernej

I could do that, but as any updated piece of SW, it needs testing, for which I don't have time at this moment.

giaur500

Yes but addon has nothing to the rest of software, especially kodi and the rest of the stuff. You could only manage to build zip snd eventually share it. I can test it.

In any case, thanks for tips, I will try to build it by myseflf. Are there any changes in original sources needed to get this addon working on OrangePi? If so, that could make recent changes made by addon dev incompatible and this can be a problem.

jernej

giaur500 replied at 2016-6-23 21:34
Yes but addon has nothing to the rest of software, especially kodi and the rest of the stuff. You co ...

I didn't change anything for "official" addons. Please check this file: https://github.com/jernejsk/Open ... .filters/package.mk PKG_VERSION will tell you commit ID from which code is taken. In this particular case code base is half a year old, but I would prefer to leave it at same version as in upstream OpenELEC for multiple reasons.

giaur500

Well, ok I guess pure Linux version is ok in this case. It was not obvious, because special platforms like RaspberryPi or Android need various tweaks to make dsp addons working. Actually Android is still not suppoted, not sure about Rpi
I thought you also made some changes specific for OrangePi, but it looks there are no any changes needed. And obviously, Allwinner platform is not suppoted officially.

giaur500

I guess I can simply change git repo url to force chekcout from unofficial repo, in package.mk, currently it's set to official Openelec git:

1. PKG_GIT_URL="https://github.com/kodi-adsp/adsp.biquad.filters"

Copy code